Skip to content

NO-SNOW: fix 3.10 failures, improve coverage#4252

Merged
sfc-gh-aling merged 4 commits into
mainfrom
aling-fix-ci
Jun 8, 2026
Merged

NO-SNOW: fix 3.10 failures, improve coverage#4252
sfc-gh-aling merged 4 commits into
mainfrom
aling-fix-ci

Conversation

@sfc-gh-aling

Copy link
Copy Markdown
Collaborator
  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

Fixes regressions from removing Python 3.9 (#4218) and improves merge-gate coverage for 3.10/3.11.

  • test_environment.yml: Bump scikit-learn from 1.0.1 → 1.2.0 so it resolves on Snowflake with python=3.10 (1.0.x has no Python 3.10 builds in Snowflake’s Anaconda channel).
  • precommit.yml: Add two integration test matrix jobs — Python 3.10 on AWS/Ubuntu and Python 3.11 on Azure/Windows — so packaging tests like test_add_requirements_yaml actually exercise the Snowflake UDF path on 3.10 (previously skipped on 3.12+ due to the cloudpickle version check).
  • FIPS CI: Migrate from EOL centos:8 to rockylinux:9 with Python 3.11 (python310 RPMs don’t exist on EL8). Update Dockerfile, test_fips.sh, and daily_precommit.yml accordingly; fix OpenSSL FIPS install to use the built binary and auto-detect the fips.so path across architectures.
  1. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
    • I acknowledge that I have ensured my changes to be thread-safe. Follow the link for more information: Thread-safe Developer Guidelines
    • If adding any arguments to public Snowpark APIs or creating new public Snowpark APIs, I acknowledge that I have ensured my changes include AST support. Follow the link for more information: AST Support Guidelines
  2. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

@@ -1,4 +1,4 @@
FROM centos:8
FROM rockylinux:9

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

snowflake python connector uses rocklinux:9 for their CI base image in the public repo

@sfc-gh-aling

sfc-gh-aling commented Jun 8, 2026

Copy link
Copy Markdown
Collaborator Author

@codecov-commenter

codecov-commenter commented Jun 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.49%. Comparing base (dc4deee) to head (f885e56).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4252      +/-   ##
==========================================
+ Coverage   95.39%   95.49%   +0.10%     
==========================================
  Files         171      171              
  Lines       44252    44184      -68     
  Branches     7559     7534      -25     
==========================================
- Hits        42215    42195      -20     
+ Misses       1250     1226      -24     
+ Partials      787      763      -24     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sfc-gh-aling sfc-gh-aling merged commit 8a140ef into main Jun 8, 2026
107 of 112 checks passed
@sfc-gh-aling sfc-gh-aling deleted the aling-fix-ci branch June 8, 2026 21:33
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 8, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants